riscv-crypto icon indicating copy to clipboard operation
riscv-crypto copied to clipboard

Published 20 hours ago • verified publisher icon riscv

The vsha2c output need to be the same in latest crypto draft 20220916

Open timhsu404 opened this issue 2 years ago • 3 comments

The output format is dirrerent in description and pseudocode. Which one should we follow?

vd = {a, b, e, f}; //in description
or
vd = {f,e,b,a); //in pseudocode

timhsu404 avatar Sep 19 '22 09:09 timhsu404

@nibrunieAtSi5 EricCheng2222 for issue tracing.

timhsu404 avatar Sep 19 '22 09:09 timhsu404

@kdockser it seems our ordering is not consistent in https://github.com/riscv/riscv-crypto/blob/master/doc/vector/insns/vsha2c.adoc

Should a be the least significant element (element 0, bytes 0 to 3 for SHA-256 and bytes 0 to 7 for SHA-512) or the other way around ? How do we express this, I would have assumed: {lowest element, ... , high element} , is this correct ?

nibrunieAtSi5 avatar Oct 13 '22 21:10 nibrunieAtSi5

We are in the process of cleaning up the pseudo code. This is one of the items will be resolved in these changes.

kdockser avatar Oct 18 '22 16:10 kdockser

This has been updated to be consistent between the pseudo-code and the specification.

kdockser avatar Oct 29 '22 19:10 kdockser