riscv-tests icon indicating copy to clipboard operation
riscv-tests copied to clipboard

Enable HwbpManual

Open lz-bro opened this issue 1 year ago • 4 comments

Change-Id: I2ee8718f03d6e381369b7d3bb0222563789ed525

lz-bro avatar Mar 01 '24 02:03 lz-bro

@aap-sc hello,I have made some modifications to support wide range of platforms. Could you please review it.

lz-bro avatar Nov 01 '24 07:11 lz-bro

@lz-bro I think it would be better to leave set_manual_trigger and just perform 2 separate calls (for type2 and type6) passing the desired mask along the way (if type2/type6 triggers require a different mask). @en-sc would you kindly take a look too?

aap-sc avatar Nov 02 '24 12:11 aap-sc

@lz-bro I think it would be better to leave set_manual_trigger and just perform 2 separate calls (for type2 and type6) passing the desired mask along the way (if type2/type6 triggers require a different mask). @en-sc would you kindly take a look too?

Thanks, I agree that perform 2 separate calls (for type2 and type6)

lz-bro avatar Nov 05 '24 03:11 lz-bro

@en-sc Passing both type_none and type_match as an argument of set_manual_trigger() ?Which parameter are you referring to as a function argument . Or is the maskmax, If so, maskmax is preset, I cannot get it befor read tdata1

lz-bro avatar Nov 06 '24 14:11 lz-bro