riscv-perf-model icon indicating copy to clipboard operation
riscv-perf-model copied to clipboard

clang-format in place, but not applied

Open ghost opened this issue 8 months ago • 0 comments

Hi,

Thanks for uploading the .clang-format file. I tried applying the .clang-format to the files in this repo but it modifies all the files. For e.g.

diff --git a/core/Decode.cpp b/core/Decode.cpp
index 90e8f75..139d97e 100644
--- a/core/Decode.cpp
+++ b/core/Decode.cpp
@@ -1,6 +1,5 @@
 // <Decode.cpp> -*- C++ -*-

-
 #include <algorithm>

 #include "Decode.hpp"
@@ -12,20 +11,15 @@ namespace olympia
 {
     constexpr char Decode::name[];

-    Decode::Decode(sparta::TreeNode * node,
-                   const DecodeParameterSet * p) :
-        sparta::Unit(node),
-        fetch_queue_("FetchQueue", p->fetch_queue_size, node->getClock(), &unit_stat_set_),
-        num_to_decode_(p->num_to_decode)
+    Decode::Decode(sparta::TreeNode* node, const DecodeParameterSet* p) : sparta::Unit(node),
+                                                                          fetch_queue_("FetchQueue", p->fetch_queue_size, node->getClock(), &unit_stat_set_),
+                                                                          num_to_decode_(p->num_to_decode)

Can you please let me know if this is the expected behaviour? Is the .clang-format file meant for newly added files/code only? I used clang-format-15 to apply the format.

Originally posted by @RamVarad in https://github.com/riscv-software-src/riscv-perf-model/discussions/100

ghost avatar Oct 16 '23 17:10 ghost