zeth icon indicating copy to clipboard operation
zeth copied to clipboard

feat: enable CI for pull request

Open dyxushuai opened this issue 1 year ago • 7 comments

Related #75 #76 +r @Wollac

dyxushuai avatar Jan 18 '24 00:01 dyxushuai

Could you provide more context with what this change is for? I think we should avoid the whitespace changes and use a common formatter/lint tool to ensure different users don't introduce different whitespace.

flaub avatar Jan 18 '24 00:01 flaub

Could you provide more context with what this change is for? I think we should avoid the whitespace changes and use a common formatter/lint tool to ensure different users don't introduce different whitespace.

Related to this pr https://github.com/risc0/zeth/pull/75#issuecomment-1896273565

dyxushuai avatar Jan 18 '24 02:01 dyxushuai

I think we should avoid the whitespace changes and use a common formatter/lint tool to ensure different users don't introduce different whitespace.

Yeah, I agree. This file was formatted by the suggestion of this issue in official vscode github action extension marketplace.visualstudio.com/items?itemName=GitHub.vscode-github-actions.

dyxushuai avatar Jan 18 '24 02:01 dyxushuai

Yeah, I agree. This file was formatted by the suggestion of this issue in official vscode github action extension marketplace.visualstudio.com/items?itemName=GitHub.vscode-github-actions.

FYI, https://marketplace.visualstudio.com/items?itemName=redhat.vscode-yaml

dyxushuai avatar Jan 18 '24 03:01 dyxushuai

If we want to start enforcing a style on these files, then we need to have a CI check to ensure that the file can't be landed in a bad style.

flaub avatar Jan 18 '24 03:01 flaub

good idea, using CI lints CI file, haha

dyxushuai avatar Jan 23 '24 11:01 dyxushuai

good idea, using CI lints CI file, haha

@flaub I added yamllint for CI files and tested it locally. It worked as expected.

dyxushuai avatar Jan 24 '24 09:01 dyxushuai