zeth
zeth copied to clipboard
The CI doesn't trigger the Clippy action
Independent issue for tracking the CI problem. The original discussion: https://github.com/risc0/zeth/pull/64#pullrequestreview-1775562186
My opinion: https://github.com/risc0/zeth/pull/64#issuecomment-1851969881
I think it doesn't add Clippy component in the risc0/risc0/.github/actions/rustup
action.
Perhaps we can add the snippet:
with:
components: clippy
clippy:
name: clippy
runs-on: ubuntu-latest
timeout-minutes: 30
steps:
- uses: actions/checkout@v3
with:
submodules: recursive
- uses: risc0/risc0/.github/actions/[email protected]
with:
components: clippy
- uses: risc0/risc0/.github/actions/[email protected]
- uses: risc0/clippy-action@main
with:
reporter: 'github-pr-check'
fail_on_error: true
github_token: ${{ secrets.GITHUB_TOKEN }}
clippy_flags: --workspace --all-targets --all-features -- -Dwarnings
In general, the CI triggers reviewdog [clippy]
(e.g. https://github.com/risc0/zeth/runs/19521165223). However, it seems to depend on the module 🤔
Maybe it is related to the fact that clippy does not work from the command line...
In general, the the CI triggers
reviewdog [clippy]
(e.g. risc0/zeth/runs/19521165223). However, it seems to depend on the module 🤔 Maybe it is related to the fact that clippy does not work from the command line...
I got lots of context from you. I want to give the issue a try in the coming days.