ripple-client icon indicating copy to clipboard operation
ripple-client copied to clipboard

[FIX] fix parsing incoming trust lines

Open darkdarkdragon opened this issue 10 years ago • 5 comments

JsonRewriter: correctly parse limit, limit_peer and noRipple properties of incoming trust line transaction Trust Tab: correctly show "Rippling" field for incoming trust lines

darkdarkdragon avatar Jan 30 '15 02:01 darkdarkdragon

show Rippling for incoming trust lines? where do you show a rippling for incomings?

vhpoet avatar Jan 30 '15 18:01 vhpoet

develop-fix-trust-line-parsing-1

  1. Rippling incorrectly shown for incoming trustlines
  2. For just-created incoming trust line limit is not in place - it must be in "Min"
  3. Edit turned on for just created trust line - it is unrecognized as incoming.

darkdarkdragon avatar Jan 30 '15 20:01 darkdarkdragon

Does this mean the "Rippling" is sometimes showing the incoming rippling and sometimes the outgoing one?

vhpoet avatar Feb 02 '15 18:02 vhpoet

@vhpoet It is one table for all trust lines - incoming and outgoing. But "Rippling" column shows incorrect data for incoming trustilines

darkdarkdragon avatar Feb 04 '15 11:02 darkdarkdragon

Coverage Status

Coverage remained the same at 68.75% when pulling 7de0e1bb0d0fdf09941e78eaef5de9f1881ccdcb on darkdarkdragon:develop-fix-trust-line-parsing into 70f67ba0e1513f22492bd7c41e14e0b3550c73e1 on ripple:develop.

coveralls avatar Feb 04 '15 11:02 coveralls