XLS-33 Multi Purpose token
High Level Overview of Change
- add MPT transactions: MPTokenIssuance, MPTokenIssuanceDestroy, MPTokenAuthorize, MPTokenIssuanceSet
- add MPT page
- support search by MPTID
- updates transactions: Payment, Clawback
- modified Currency to support MPTID
Context of Change
Spec: https://github.com/XRPLF/XRPL-Standards/tree/master/XLS-0033d-multi-purpose-tokens
MPT page
Ledger view
MPTokenIssuance
MPTokenAuthorize
MPTokenIssuanceSet
Payment (with scaling MPT amount)
Clawback
Type of Change
- [ ] Bug fix (non-breaking change which fixes an issue)
- [ ] New feature (non-breaking change which adds functionality)
- [ ] Breaking change (fix or feature that would cause existing functionality to not work as expected)
- [ ] Refactor (non-breaking change that only restructures code)
- [ ] Tests (You added tests for code that already exists, or your new feature included in this PR)
- [ ] Documentation Updates
- [ ] Translation Updates
- [ ] Release
TypeScript/Hooks Update
- [ ] Updated files to React Hooks
- [ ] Updated files to TypeScript
Before / After
Test Plan
Noticed 2 MPT Issuance IDs on top of each other in the screenshot for MPT page
Noticed 2 MPT Issuance IDs on top of each other in the screenshot for MPT page
That's because it's a tooltip for the ID - similar to the NFT page
I'm not sure which way is better: the current way of showing scaled amount, or just showed the amount divided by 10^scale (so that on payment and clawback simple page we dont have to click on the token itself to find out about the scale). Other than that, looks good to me.
The failed tests can be fixed when merging latest changes from staging
I'm not sure which way is better: the current way of showing scaled amount, or just showed the amount divided by 10^scale (so that on payment and clawback simple page we dont have to click on the token itself to find out about the scale). Other than that, looks good to me.
Personally, I'd rather see the scaled amount instead of having to do the math myself.
I'm not sure which way is better: the current way of showing scaled amount, or just showed the amount divided by 10^scale (so that on payment and clawback simple page we dont have to click on the token itself to find out about the scale). Other than that, looks good to me.
Personally, I'd rather see the scaled amount instead of having to do the math myself.
@mvadari @pdp2121 One problem with showing the amount divided by 10^scale that is the information of the AssetScale is stored in the MPTokenIssuance object. This means that whenever MPT amount is display, we would need to make an extra call using the ledger_entry API to fetch the MPTokenIssuance object to get the scale.
This means that whenever MPT amount is display, we would need to make an extra call using the ledger_entry API to fetch the MPTokenIssuance object to get the scale.
I think that's fine.
This means that whenever MPT amount is display, we would need to make an extra call using the ledger_entry API to fetch the MPTokenIssuance object to get the scale.
I think that's fine.
Yes. I would prefer seeing the scaled amount. We are also showing scaled amount in PriceOracles tx.
LGTM. Just left a comment and may be get the linting fixed
Not quite sure why the lint fails, the ones that are failing are the ones that my local linter told me to fix.