explorer icon indicating copy to clipboard operation
explorer copied to clipboard

Breakdown tab for payments and offercreates

Open shortthefomo opened this issue 1 year ago • 2 comments

This PR adds a breakdown section to payments and offercreates

Context of Change

This adds the ability to show where the liquidity for the transaction was sourced. Via AMM/DEX/DIRECT and if RIPPLING was involved.

Screenshot 2024-05-22 at 12 36 05 PM

Type of Change

  • [ ] Bug fix (non-breaking change which fixes an issue)
  • [ ] New feature (non-breaking change which adds functionality)
  • [ x] Breaking change (fix or feature that would cause existing functionality to not work as expected)
  • [ ] Refactor (non-breaking change that only restructures code)
  • [ ] Tests (You added tests for code that already exists, or your new feature included in this PR)
  • [ ] Documentation Updates
  • [ ] Translation Updates
  • [ ] Release

shortthefomo avatar May 22 '24 16:05 shortthefomo

Looks awesome! Probably the dropdown would need a bit redesign, which could be great for reusability as well: Screenshot 2024-05-22 at 6 45 50 PM

pdp2121 avatar May 22 '24 17:05 pdp2121

Please add tests.

now in place, I think its ready for another round of review now.

shortthefomo avatar May 24 '24 20:05 shortthefomo