explorer icon indicating copy to clipboard operation
explorer copied to clipboard

fix: use `Currency` in the metadata description

Open mvadari opened this issue 10 months ago • 2 comments

High Level Overview of Change

This PR adds the use of the Currency element to the metadata processing, so that proper hex-converted currency codes are used and there are links to the currency pages.

Context of Change

It is difficult to read when currencies that have a code longer than 3 characters aren't displayed properly.

Type of Change

  • [x] Bug fix (non-breaking change which fixes an issue)
  • [ ] New feature (non-breaking change which adds functionality)
  • [ ] Breaking change (fix or feature that would cause existing functionality to not work as expected)
  • [ ] Refactor (non-breaking change that only restructures code)
  • [ ] Tests (You added tests for code that already exists, or your new feature included in this PR)
  • [ ] Documentation Updates
  • [ ] Translation Updates
  • [ ] Release

TypeScript/Hooks Update

  • [ ] Updated files to React Hooks
  • [ ] Updated files to TypeScript

Before / After

Before: image

After: image

Test Plan

TODO

mvadari avatar Apr 18 '24 21:04 mvadari

Is it for https://github.com/ripple/explorer/issues/925?

pdp2121 avatar Jul 09 '24 14:07 pdp2121

Is it for #925?

Yes, I forgot there was an issue.

mvadari avatar Jul 09 '24 14:07 mvadari