explorer icon indicating copy to clipboard operation
explorer copied to clipboard

Highlight when `TrustSet` freezes or unfreezes a trust line in the "Simple" view

Open ckniffen opened this issue 2 years ago • 6 comments

Use tfSetFreeze and tfClearFreeze to highlight on the left of the "SimpleTab" view to show "Frozen" or "Unfrozen" respecitivly.

Wording may need updating. Thoughts @mduo13 @bugsbunnies @nataliacebotarii

Example Transactions:

ckniffen avatar Oct 07 '22 19:10 ckniffen

The left of the Simple tab view right now has a label and a value, I think we can add "Frozen" or "Unfrozen" as the value but what should the label say? Flags? @ckniffen

bugsbunnies avatar Oct 10 '22 20:10 bugsbunnies

Trustline Status? It's not covering all flags

mvadari avatar Oct 10 '22 21:10 mvadari

Trustline Status? It's not covering all flags

The flags do show up but are buried on the details page. I feel like freeze use-cases should have greater visibility.

ckniffen avatar Oct 10 '22 23:10 ckniffen

I'm supportive; maybe it should be clear who's freezing the line since depending on which side is [currently] the issuer the implications of freezing/unfreezing the line are different.

mDuo13 avatar Nov 16 '22 21:11 mDuo13

How would you for see the messaging being different?

ckniffen avatar Nov 17 '22 03:11 ckniffen

I am not sure what the expected display is; as long as it's clear who's doing the freezing—i.e. if the sender of the transaction is obvious from the display that's OK.

Possibly a better display would be possible if you can identify who's the issuer on the trust line (that is, whose balance is negative from their perspective). You could add a warning/tip note if the freeze is enacted by the holder, not by the issuer, because the semantics of what happens in that case are perhaps counter to what most users expect. The Individual Freeze docs have the details:

An individual address can freeze its trust line to a financial institution. This has no effect on transactions between the institution and other users. It does, however, prevent other addresses, including operational addresses, from sending that financial institution's tokens to the individual address. This type of individual freeze has no effect on offers.

In other words, if you freeze your own trust line then you can't get more of that token even from the token issuer's hot wallet. I think even direct transactions can't increase your balance on that trust line? But you can still send/spend it.

mDuo13 avatar Nov 18 '22 21:11 mDuo13