explorer icon indicating copy to clipboard operation
explorer copied to clipboard
verified publisher icon ripple

fix: Upgrade Status renders on data error

Open pdp2121 opened this issue 1 year ago • 4 comments

High Level Overview of Change

The VHS is experiencing an intermittent issue with CORS header that causes occasional disruption in data fetching for the Upgrade Status chart. This PR will add checks so to ensure the chart renders even when there's a disruption.

Screenshot 2024-06-12 at 4 13 54 PM

Type of Change

  • [x] Bug fix (non-breaking change which fixes an issue)
  • [ ] New feature (non-breaking change which adds functionality)
  • [ ] Breaking change (fix or feature that would cause existing functionality to not work as expected)
  • [ ] Refactor (non-breaking change that only restructures code)
  • [ ] Tests (You added tests for code that already exists, or your new feature included in this PR)
  • [ ] Documentation Updates
  • [ ] Translation Updates
  • [ ] Release

pdp2121 avatar Jun 12 '24 20:06 pdp2121

I will add test cases

pdp2121 avatar Jul 05 '24 16:07 pdp2121

@mvadari I have updated the logic. Aggregation for nodes and validators will be handled separately (in case one fails, it would still update the other).

pdp2121 avatar Jul 08 '24 21:07 pdp2121

Not sure why npm run test:ci succeed locally but fails on GitHub

pdp2121 avatar Jul 08 '24 22:07 pdp2121

Not sure why npm run test:ci succeed locally but fails on GitHub

Usually due to flakiness or something, or missing an async/await somewhere.

mvadari avatar Jul 08 '24 22:07 mvadari