R.I.Pienaar

Results 312 comments of R.I.Pienaar

Curious though is this really necessary? Do we service the waiting pulls in random order? I thought we do that to avoid a bad client doing a huge pull and...

I did some spelunking in the code and it seems these are generated - among others - when a limit is evicting a message that is still being processed (we...

Well its just ruby strings, so standard ruby quote escaping would probably work

@piotrpio looking at the go PR its returning `[]string` but here it says we should be returning equiv of `Status()` which you can do in one API call rather than...

@piotrpio my bad, I didnt see you also added a way to get the status, sorry

@piotrpio Yeah, sorry for the back and forth, but the `KeyValueStores()` returns `KeyValue`, to get status would then be another API call for every stream :( The streams api call...

Yeah, its a bit sad - and the alternatives are not great from a dependencies perspective

I cant find an easy to use option for this, might need to look into a custom `tlsc`, at which point we can also support verification being disabled.

> @ripienaar For the schema and CLI, it appears you checked these off, but the PRs apply to the metadata fields rather than support for multiple subject filters. thanks, fixed!

> @ripienaar FYI: reference to [ADR-9](https://github.com/nats-io/nats-architecture-and-design/blob/main/adr/ADR-9.md) points to page not found. I don't think there is such ADR at the moment? fixed :) actually, something else going on...