mapperly icon indicating copy to clipboard operation
mapperly copied to clipboard

Fix name collision on inlined mapping

Open faddiv opened this issue 1 month ago • 1 comments

Fix name collision on inlined mapping

Description

This PR ensures that the inlined mapping in the projections doesn't cause parameter collision.

Fixes #2012

Checklist

  • [x] The existing code style is followed
  • [x] The commit message follows our guidelines
  • [x] Performed a self-review of my code
  • [ ] Hard-to-understand areas of my code are commented
  • [ ] The documentation is updated (as applicable)
  • [x] Unit tests are added/updated
  • [ ] Integration tests are added/updated (as applicable, especially if feature/bug depends on roslyn or framework version in use)

faddiv avatar Nov 25 '25 19:11 faddiv

Mapperly usally works top to bottom. Here, the approach is inversed (the parameter names are reserved from the innermost mapping). I'd prefer doing it the other way around (that's what I tried): rewriting the inlined mapping with unique parameter names. That's actually also what we do for the source parameter.

latonz avatar Dec 04 '25 12:12 latonz

Feel free to reopen with a rewrite parameters approach 😊 Closing for now as no update was provided for a couple of weeks.

latonz avatar Dec 24 '25 15:12 latonz