Explicit named mappings
Explicit named mappings
Description
This PR implements the NamedMappingAttribute so the method names can be overridden with an explicit name.
Fixes #1855
Checklist
- [x] The existing code style is followed
- [x] The commit message follows our guidelines
- [x] Performed a self-review of my code
- [x] Hard-to-understand areas of my code are commented
- [x] The documentation is updated (as applicable)
- [x] Unit tests are added/updated
- [x] Integration tests are added/updated (as applicable, especially if feature/bug depends on roslyn or framework version in use)
Currently, I use the name resolution where it is needed, but it is more optimal to store this somewhere. I have an idea to bring the custom method name resolution into MethodMapping. There is a MethodName already.
What are you referring to under "name resolution"? Your current GetMethodName method? I don't think the MethodMapping would be a good fit for this. Instead I'd probably move it to SymbolAccessor.
Hi @latonz, When will you have time to look at this PR?
Hey @faddiv, sorry about that. I did not have this on my to-do list, maybe because no new review was requested. I will review it as soon as I get the time, early next week at the latest. Apologies again for the delay.
Sorry, I didn't know that I had to request it.