mapperly icon indicating copy to clipboard operation
mapperly copied to clipboard

feat: make `targetMembers` case sensitive

Open TimothyMakkison opened this issue 1 year ago • 1 comments

Description

Having two members with case insensitive similar names would cause mapperly to fail. value & Value

  • Make TargetMember case sensitive
  • Added case insensitive member removal for constructors
  • Added a test

Fixes #1076

Checklist

  • [x] The existing code style is followed
  • [x] The commit message follows our guidelines
  • [x] Performed a self-review of my code
  • [x] Hard-to-understand areas of my code are commented
  • [x] Unit tests are added/updated

TimothyMakkison avatar Jan 21 '24 23:01 TimothyMakkison

Codecov Report

All modified and coverable lines are covered by tests :white_check_mark:

Comparison is base (e606f93) 91.18% compared to head (1854967) 91.18%.

Additional details and impacted files
@@            Coverage Diff             @@
##             main    #1077      +/-   ##
==========================================
- Coverage   91.18%   91.18%   -0.01%     
==========================================
  Files         220      220              
  Lines        7203     7201       -2     
  Branches      915      915              
==========================================
- Hits         6568     6566       -2     
  Misses        418      418              
  Partials      217      217              

:umbrella: View full report in Codecov by Sentry.
:loudspeaker: Have feedback on the report? Share it here.

codecov[bot] avatar Jan 21 '24 23:01 codecov[bot]