rio-labs
Clearly Distinguish Sensitive from Insensitive Components
Some components look virtually identical regardless of whether they're sensitive or not. Look through all components and make sure that's not the case.
For example, rio.Textinput:
Beautiful. Thank you!
We're very active in discord if you need help with anything
Okay I have gone through the project once, and now have a few questions. What exactly qualifies as sensitive and Insensitive?. And the way I am going to go about doing this task is:
- I created a new rio project called my-project.
- I am going to check each component by importing it into this project and find out the sensitive and the insensitive components.
- Change them so that its obvious which are sensitive and which are not. Any suggestions on this workflow? I will also ask the same on discord as you said you are active there too.
I think you're misunderstanding something. It's not that some components are sensitive and some aren't, but rather, there are some components that have a is_sensitive parameter. For example, TextInput, Slider, Button, etc. The problem that needs to be solved is that a rio.TextInput(is_sensitive=True) looks too similar to a rio.TextInput(is_sensitive=False).
Looking at the Dropdown demo, TextInput demo, and the explanation of the parameter ("Whether the dropdown / text input should respond to user input"), my feedback is threefold:
- The color scheme of the disabled Dropdown clearly indicates a difference from its enabled state, whereas the TextInput is almost identical - implement the Dropdown background coloring throughout
- The text of the disabled TextInput is much more visible than that of the disabled Dropbown - implement a suitable dark text color once (1) is changed
- The choice of "is_sensitive = True" to enable editing is confusing, so perhaps it would be better to change this to something like "is_sensitive = False" or "is_editable = True" or "is_readonly = True"
