Gerald R. comments

Results 68 comments of


                                            Gerald R.

[BUGFIX] Fix dashboard widgets for v12

@extcode The violation that is marked in the coding guideline is fixed in #477. Best to merge that first, afterwards I will rebase this commit.

[TASK] Check stock during order process

@extcode I need to add a changelog as well but I want to wait until you gave some feedback ;)

Maxitems for column not working in workspaces

I can confirm this error in TYPO3 v13 with EXT:content_defender v3.5.2 when working in workspace with `maxitems`.

[CLEANUP] Rename build folders

For another topic I had a look at EXT:tea and EXT:blog_example (both being best practice examples) but none of them uses small case for the `Build` folder. https://github.com/TYPO3-Documentation/blog_example/tree/main/Build https://github.com/FriendsOfTYPO3/tea/tree/main/Build So...

BeVariant throws a PHP Runtime Deprecation Notice

So this is solved and can be closed!? :)

[CLEANUP] ignore php warning if no page is selected via the page tree

@dontWatchMeCode maybe I missed something so therefore: Why did you add a `@` before the `$this`?

[CLEANUP] ignore php warning if no page is selected via the page tree

Interesting. Thanks for the input. It's not me to decide whether to go this way but: I cannot reproduce this error at all.

[CLEANUP] ignore php warning if no page is selected via the page tree

Wait... I really need to setup a extra TYPO3 for the EXT:cart stuff...

[CLEANUP] ignore php warning if no page is selected via the page tree

I can imagine that @extcode prefers something like ```php $pageId = isset($this->request->getQueryParams()['id']) ? (int)$this->request->getQueryParams()['id'] : 1; ``` to not block warning that we are not expecting at the moment.

[CLEANUP] ignore php warning if no page is selected via the page tree

Yes, I meant with "wait..." that I had a wrong configuration. Now I can reproduce the error. But it's solved with the code snippet that I wrote above.