Matthew Hoffman

MacOS 13.5, control trouble with Spotlight Search & emoji keyboard

3

While trying to relearn the controls after last playing this like 20 years ago (holy shit and thank you for your work on this port!)... I found myself triggering: *...

torch.Tensor.sort return type values access PD011 false positive

1

**Describe the bug** I am getting a `PD011` warning about accessing the `values` attribute of the `torch.Tensor.sort` return type `NamedTuple`. **To Reproduce** ```toml [tool.ruff.lint] select = [ 'PD', # pandas-vet...

When I run the CLI using `0.8.8` on PyPI I get the following: ```python # # © 2022 XXX, Inc. All rights reserved.# ``` but when I run the source...

import sorting?

9

When I use this `pyproject.toml` config: ```toml [tool.ruff] select = [ "I", # isort formatting. ] ``` And this `.pre-commit-config.yaml`: ```yaml repos: - repo: https://github.com/charliermarsh/ruff-pre-commit rev: v0.1.13 hooks: - id:...

Variadic tuple unpacking requires a star target -- why?

2

**Bug Report** When attempting to unpack a `tuple` that uses `Unpack`, if you don't use a star target to capture the variadic `tuple` as a `list`, you get the error...

Add `step` parameter to `TensorBoardLogger.log_hyperparams`

2

## What does this PR do? Adds a `step` parameter to `TensorBoardLogger.log_hyperparams`. This also mirrors the `global_step` param of [`torch.utils.tensorboard.SummaryWriter.add_hparams`](https://pytorch.org/docs/stable/tensorboard.html#torch.utils.tensorboard.writer.SummaryWriter.add_hparams). Currently, the metrics that get logged using this method are...

Use `importlib.util.find_spec` to check if `lm_eval` is installed instead of trying to import it

2

There is a circular dependency when trying to import `lm_eval` inside `torchao`. The chain is like this: torchao -> lm_eval -> transformers.pipelines -> torchao And results in the following error:...

Should we require a specific version of `lm_eval` to simplify `torchao/_models/_eval.py`?

1

As a follow-up to: * https://github.com/pytorch/ao/pull/1023 It is good practice to avoid having bare except clauses that suppress all errors. **cc**: @msaroufim --- A lot of the try/except blocks in...

Refactor `tiktoken` import bare except

1

We shouldn't suppress the import error if `tiktoken` is not installed. Also do the same thing for `sentencepiece`. Instead of importing them at the top of the file, we can...

### System Info - `transformers` version: 4.46.0.dev0 - Platform: Linux-5.15.0-122-generic-x86_64-with-glibc2.35 - Python version: 3.10.14 - Huggingface_hub version: 0.24.7 - Safetensors version: 0.4.5 - Accelerate version: 0.34.2 - PyTorch version (GPU?):...