ring icon indicating copy to clipboard operation
ring copied to clipboard

Clarify what request-header-size and response-header-size mean

Open mikekap opened this issue 4 years ago • 4 comments

Jetty's config options are for the PROTOCOL header, not a single Field: Value pair. So these options control the sum of all headers and status lines.

mikekap avatar May 04 '21 00:05 mikekap

Commit messages of this repository should follow the seven rules of a great Git commit message, as mentioned in the project's contributing guidelines. It looks like there's a few issues with the commit messages in this pull request:

  • The commit message subject is over 50 characters.
  • The commit message body has a line over 72 characters.

atomist[bot] avatar May 04 '21 00:05 atomist[bot]

Do you have a source for that? I ask not to doubt, but so we have a record of why changes were made.

weavejester avatar May 04 '21 00:05 weavejester

Unfortunately Jetty hasn't quite updated the docs, but this was the only source that I could find: https://github.com/eclipse/jetty.project/issues/6204#issuecomment-823907944 . The other way is to read through the code and notice that the length is used to allocate a buffer that includes the status line and all the headers.

mikekap avatar May 04 '21 00:05 mikekap

Thanks. From my reading of the link you provided, the sizes don't include the request/response line.

weavejester avatar May 07 '21 15:05 weavejester