ring
ring copied to clipboard
ring-clojure
HTTP2 support?
Any plans for http2 support?
This fork has it https://github.com/sunng87/ring-jetty9-adapter
Is it possible to implement officially?
You mean update the Jetty adapter? The only blocker is that Jetty tends to use the latest JVM versions, so updating Jetty means updating the minimum JVM version. And there are always third-party adapters that support HTTP/2 like the one you linked. Ring itself doesn't care if you're sending data through HTTP 1.0, 1.1 or 2.
Hey @weavejester! Yes, the adapter, sorry about not specifying it.
The thing is that I've opened a PR on another project and got this response:
Hey @sabino, thanks for this PR. We're looking forward to enabling HTTP 2 support, but we'd rather wait until it's supported upstream by Ring instead of switching to an unofficial fork.
That's why I'm asking if there are any plans for HTTP2 support officially. Thank you!
It likely won't be for a while yet, as supporting HTTP/2 through Jetty requires updating the minimum required JVM version. For obvious reasons, we'd like to support as many JVM versions for as long as we can.
Any change on this issue now that Clojure 1.10 requires Java 8 as a minimum, and earlier versions are out of mainstream support?
Ring uses Jetty 9 now, so adding HTTP/2 support shouldn't be too much trouble.
There are a bunch of concepts in HTTP/2 that currently don't have a standard "ring way" to express them. For example server push sounds like something that might need some changes to the request-map response-map model. Do you have ideas how to expose stuff like that in the ring api?
I'm thinking of implementing HTTP/2 support in my fork of Aleph, and if ring had a spec for HTTP/2 stuff I'd follow that to stay compatible.
Adding HTTP/2 support to Ring's existing feature set shouldn't be too difficult, but adding support for new functionality like server push is something I haven't even begun to consider.
@weavejester: Did HTTP/2 support happen, or are you planning to switch your focus to Ring 2.0?
HTTP/2 support is part of Ring 2.0. However, other adapters can certainly implement it in the meantime, as least so far as the current Ring specification allows.