ring-anti-forgery icon indicating copy to clipboard operation
ring-anti-forgery copied to clipboard

Removes dependecy of apache-commons to enable babashka users to use ring-anti-forgery

Open m3tti opened this issue 1 year ago • 4 comments

The merge request removes a library with apache-commons dependency and replaces the functionality with plain Java functions. This is needed to get ring-anti-forgery to work with babashka.

Would be nice if you would consider my pull request.

m3tti avatar Sep 05 '24 21:09 m3tti

Apologies for the delay in looking at this. This seems a reasonable change. Can you remove all irrelevant changes (e.g. deps.edn), squash the commits down, and set the commit message to:

Remove dependency on crypto-random

Remove crypto-random dependency and transitive dependency commons-codec
in order to make this library compatible with Babashka.

weavejester avatar Oct 18 '24 12:10 weavejester

will do asap

m3tti avatar Oct 21 '24 17:10 m3tti

ok i've tried to remove the deps.edn but it is required to work with babashka as it seems but i'll try to get in touch with @borkdude

m3tti avatar Oct 21 '24 17:10 m3tti

If this lib is published to clojars, you don't need a deps.edn, but it would be nice to have a deps.edn so you could use this library as a git dependency. I assume @weavejester wants a different issue + PR for that, if he is open to that?

borkdude avatar Oct 21 '24 18:10 borkdude

Just coming back to this. A deps.edn file can be added in a separate PR, but is not required for this PR and so should be removed. I'll merge once the deps.edn file is removed from the commit.

weavejester avatar Jan 23 '25 06:01 weavejester

I manually merged this and also fixed the failing tests.

weavejester avatar Jan 24 '25 05:01 weavejester

thank you so much!!!

m3tti avatar Feb 02 '25 18:02 m3tti