librime icon indicating copy to clipboard operation
librime copied to clipboard
verified publisher icon rime

Remember to shutdown logging when rime is finalized normally

Open WhiredPlanck opened this issue 2 years ago • 2 comments

Pull request

Issue tracker

Fixes will automatically close the related issue

Fixes #

Feature

Describe feature of pull request

... to prevent potential memory leaks.

Unit test

  • [x] Done

Manual test

  • [ ] Done

Code Review

  1. Unit and manual test pass
  2. GitHub Action CI pass
  3. At least one contributor reviews and votes
  4. Can be merged clean without conflicts
  5. PR will be merged by rebase upstream base

Additional Info

WhiredPlanck avatar Oct 30 '23 09:10 WhiredPlanck

In a typical Rime program flow, RimeInitialize and RimeFinalize are called in pairs. SetupLogging isn't done in RimeInitialize, therefore it should not be shut down in RimeFinalize.

lotem avatar Nov 19 '23 15:11 lotem

In a typical Rime program flow, RimeInitialize and RimeFinalize are called in pairs. SetupLogging isn't done in RimeInitialize, therefore it should not be shut down in RimeFinalize.

You are right. But I still think that shutting down the logging makes sense, where should I put it to?

WhiredPlanck avatar Nov 20 '23 05:11 WhiredPlanck