rilysh

f0a666e914d718ebdcc27763d2870bb0da4fcbc2, 8aafb0560ac47442251b693bb0a79f25e52b8d94, and 8d40c6a559c7b2dd6529b1ec3a91b88cf02d52e8 are sorted from OpenBSD. Others are just diffs (from OpenBSD) (where I found these typos).

bsdinstall/distfetch.c: check environment variables before downloading and handle memory allocation errors

1

1. Currently, distfetch checks environment variables existence when it will use them or in a case (in chdir()) it doesn't check at all. As they are necessary to set before...

exit.3: add the comma after an empty space

1

exit(3) man page shows __cxa_atexit(3,) instead of __cxa_atexit(3), in a particular section. It seems the comma gets inside the parenthesis and with an extra space, it can be viewed as...

units.c: decrease strlen() calls and use else if in lookupunit() function

1

1. A lot of times strlen() was used to find the length of a same string. Sometimes compilers can omit these accordingly, but calls inside complex loops are often missed....

swab.c(libc): use a simplified version of byte swapping

4

This version of swab function simplifies the logic of swapping adjacent bytes. Previous version of swab() used an arbitrary unrolling, which was relevant back in the day but unnecessary for...

fdwrite.c: initialize pointers to NULL and a few other cleanups

4

1. Both trackbuf and vrfybuf are initialized to zero (NULL). While it's okay to initialize pointers to zero, to keep consistency, as they're explicitly pointers, it's better to just use...

bhyveload/bhyveload.c: avoid re-calculating path length and check if malloc(...) fails

5

1. In cb_open(...) function, strlen(3) was used two times, to retrieve the length of "path". However, we can avoid calling strlen(3) for the second time by keeping the calculated length...

1. There seem to be no package called vim-console or nano-devel in the ports tree, rather it's now just called vim or nano (depending on which one a user will...

Hello, In xbegin and xend functions, this program uses some older i386 instructions. For a proper x64-based CPU, if there's an alternative implementation won't it be better to use them...

clang++: Optimization passes can strip away deadlock loops

4

Consider the following code ```cpp #include int main() { std::cout