rill
rill copied to clipboard
Don't reconcile on ref updates when there's a cron trigger
- Previously,
refresh.ref_updatealways defaulted totrueunless explicitly overridden. This meant we'd always trigger on a ref update, even whenrefresh.cronwas set. - This PR changes the behavior so
refresh.ref_updatedefaults tofalsewhenrefresh.cronis provided. - This is a behavioral change, but perhaps worth it since it will avoid some unintended refreshes. It was originally reported as a bug where an alert with a daily cron schedule was triggering every hour due to the underlying source refresh. But this change impacts the behavior of
refresh:across alerts, reports and models.
Closes https://linear.app/rilldata/issue/PLAT-326/alert-cron-jobs-are-not-being-honored
Checklist:
- [x] Covered by tests
- [ ] Ran it and it works as intended
- [x] Reviewed the diff before requesting a review
- [ ] Checked for unhandled edge cases
- [ ] Linked the issues it closes
- [x] Checked if the docs need to be updated. If so, create a separate Linear DOCS issue
- [ ] Intend to cherry-pick into the release branch
- [x] I'm proud of this work!