rill icon indicating copy to clipboard operation
rill copied to clipboard

Don't reconcile on ref updates when there's a cron trigger

Open begelundmuller opened this issue 1 month ago • 0 comments

  • Previously, refresh.ref_update always defaulted to true unless explicitly overridden. This meant we'd always trigger on a ref update, even when refresh.cron was set.
  • This PR changes the behavior so refresh.ref_update defaults to false when refresh.cron is provided.
  • This is a behavioral change, but perhaps worth it since it will avoid some unintended refreshes. It was originally reported as a bug where an alert with a daily cron schedule was triggering every hour due to the underlying source refresh. But this change impacts the behavior of refresh: across alerts, reports and models.

Closes https://linear.app/rilldata/issue/PLAT-326/alert-cron-jobs-are-not-being-honored

Checklist:

  • [x] Covered by tests
  • [ ] Ran it and it works as intended
  • [x] Reviewed the diff before requesting a review
  • [ ] Checked for unhandled edge cases
  • [ ] Linked the issues it closes
  • [x] Checked if the docs need to be updated. If so, create a separate Linear DOCS issue
  • [ ] Intend to cherry-pick into the release branch
  • [x] I'm proud of this work!

begelundmuller avatar Dec 10 '25 19:12 begelundmuller