rill icon indicating copy to clipboard operation
rill copied to clipboard
verified publisher icon rilldata

Infinite scrolling in ShareProjectForm

Open lovincyrus opened this issue 1 month ago • 5 comments

INSERT DESCRIPTION HERE

Closes https://linear.app/rilldata/issue/APP-521/project-share-popover-is-not-displaying-full-list-of-users-that-have

Checklist:

  • [ ] Covered by tests
  • [ ] Ran it and it works as intended
  • [ ] Reviewed the diff before requesting a review
  • [ ] Checked for unhandled edge cases
  • [ ] Linked the issues it closes
  • [ ] Checked if the docs need to be updated. If so, create a separate Linear DOCS issue
  • [ ] Intend to cherry-pick into the release branch
  • [ ] I'm proud of this work!

lovincyrus avatar Nov 12 '25 07:11 lovincyrus

Ready for Product QA, modified the page size to 10. Will revert to 50 before landing this PR. @ericokuma

lovincyrus avatar Nov 12 '25 07:11 lovincyrus

https://www.loom.com/share/4707f9d1da084faaba7a36337b4f9660

ericokuma avatar Nov 13 '25 17:11 ericokuma

perfect, i'll address this

TODO: current user isn't loaded on dialog open.

lovincyrus avatar Nov 13 '25 17:11 lovincyrus

perfect, i'll address thisTODO: current user isn't loaded on dialog open.

Filed a follow-up for endpoint request to properly address this: https://linear.app/rilldata/issue/APP-570/add-a-new-endpoint-to-get-current-users-project-membership-by-email

I've added a workaround in the meantime. Ready for re-review. The current user should now appear even when you haven't scroll to the bottom of the page. @ericokuma

lovincyrus avatar Nov 14 '25 04:11 lovincyrus

To revert page size to 50 before merging.

lovincyrus avatar Nov 18 '25 12:11 lovincyrus