rill icon indicating copy to clipboard operation
rill copied to clipboard

[APP-56] Apply smart `refetchInterval` to all resource tables

Open lovincyrus opened this issue 8 months ago • 1 comments

Closes https://github.com/rilldata/rill/issues/6667

In this pull request, we introduced a custom refetch interval to repeatedly reload a resource until its status was marked as complete. That same custom refetch interval is being applied to dashboards, alerts, and reports.

  • [x] dashboards
  • [x] reports
  • [x] alerts
  • [x] modify https://github.com/rilldata/rill/blob/main/web-admin/tests/setup/setup.ts#L177-L189

Checklist:

  • [x] Covered by tests
  • [x] Ran it and it works as intended
  • [x] Reviewed the diff before requesting a review
  • [x] Checked for unhandled edge cases
  • [x] Linked the issues it closes
  • [x] Checked if the docs need to be updated
  • [ ] Intend to cherry-pick into the release branch
  • [x] I'm proud of this work!

lovincyrus avatar Apr 24 '25 21:04 lovincyrus

Additionally, mind updating the PR description?

ericpgreen2 avatar Apr 29 '25 22:04 ericpgreen2

@lovincyrus : Any updates on this PR ? Whats next here?

nishantmonu51 avatar Jul 04 '25 12:07 nishantmonu51

@lovincyrus, checking in on this PR, have you given any thought to these two comments?

image

ericpgreen2 avatar Jul 08 '25 19:07 ericpgreen2

@lovincyrus, checking in on this PR, have you given any thought to these two comments?

image

Ah, I responded in another thread https://github.com/rilldata/rill/pull/7216#discussion_r2141743261 We can certainly reconsider them

lovincyrus avatar Jul 08 '25 21:07 lovincyrus

@lovincyrus : Any updates on this PR ? Whats next here?

I plan to revisit this after completing the data connector UX sprints.

lovincyrus avatar Jul 08 '25 21:07 lovincyrus

Added the query.meta approach in the recent commits.

lovincyrus avatar Jul 29 '25 21:07 lovincyrus

@lovincyrus, is this ready to be merged?

ericokuma avatar Sep 04 '25 17:09 ericokuma