rill icon indicating copy to clipboard operation
rill copied to clipboard

--readonly mode allows to edit local files

Open azat opened this issue 1 year ago • 4 comments

To Reproduce Steps to reproduce the behavior:

  • run rill locally in folder with --readonly (rill start --readonly)
  • try to edit any file - it will be modified

Expected behavior The file should not be modified

Additional context Here https://github.com/rilldata/rill/issues/5039#issuecomment-2242720421 @begelundmuller already wrote about the same issue I guess, but it will be nice to limit the editions even for local deployment

azat avatar Sep 26 '24 15:09 azat

Hello @azat, the current --readonly support is designed to put the application into a state focused on presenting dashboards instead of developing them, but it is unfortunately not designed for securely locking down the application (as would for example be needed for hosting Rill on a server). For hosting, the only currently supported approach is using Rill Cloud (by running rill deploy from the CLI).

However thank you for sharing this feature request and we will update you if/when we support a self-hostable configuration of Rill.

begelundmuller avatar Oct 14 '24 15:10 begelundmuller

I'm closing this issue since it's currently working as intended, but let me know if I misunderstood the issue and you think it should be re-opened.

begelundmuller avatar Oct 17 '24 10:10 begelundmuller

To be honest I would expecting different behavior - --readonly should block any changes

azat avatar Oct 17 '24 12:10 azat

Yeah, this is a valid open issue, so I'll re-open. From the UI perspective, the --readonly flag should only present the "Preview" mode, not show the file editor.

ericpgreen2 avatar Oct 17 '24 13:10 ericpgreen2

We've elected to deprecate the --readonly flag. It was a relic of Rill Developer before the launch of Rill Cloud, and clearly we haven't properly maintained it. Today, dashboards should be shared with others via Rill Cloud.

ericpgreen2 avatar Nov 26 '24 15:11 ericpgreen2