rill icon indicating copy to clipboard operation
rill copied to clipboard

feat: Add multiple items in a single input component

Open AdityaHegde opened this issue 1 year ago • 1 comments

For user invite we need a single input that takes multiple items that can be deleted. This can also replace our inputs for user invite, slack users and slack channels in alerts/report forms.

Screenshot 2024-06-28 at 12 50 00 PM

AdityaHegde avatar Jun 28 '24 07:06 AdityaHegde

Your screenshot looks good to me @AdityaHegde . Typically for error states on form items we also include a line below the box describing the error. Refer to https://www.figma.com/design/nqqazRo1ckU9ooC9ym9weI/Rill-Design-System?node-id=1155-275658&t=CI3PsT3M48ovZg4e-11

jkhwu avatar Jun 28 '24 17:06 jkhwu

@AdityaHegde I know it's already been merged, but just tried the storybook component! Would it be possible to allow a comma , as a separating keystroke as well as enter? That's what I had discussed with @ericokuma when designing the UI for it (https://www.figma.com/design/Qt6EyotCBS3V6 Screenshot 2024-07-01 at 12 16 36 PM Screenshot 2024-07-01 at 12 21 25 PM

O31jVhMQ7/RILL?node-id=13326-670655&t=CzdefMI7EkO6Q1IX-11)

jkhwu avatar Jul 01 '24 19:07 jkhwu

Let's also add tab as another keystroke!

ericokuma avatar Jul 01 '24 20:07 ericokuma

Sure i will incorporate these in the UI based user invitations PR.

AdityaHegde avatar Jul 02 '24 05:07 AdityaHegde