rill icon indicating copy to clipboard operation
rill copied to clipboard

Published 20 hours ago • verified publisher icon rilldata

Rename `table` to `source`

Open ericpgreen2 opened this issue 2 years ago • 4 comments

Addresses #346.

Note that there are some cases in the code where I keep the "table" terminology – where it specifically refers to database tables and not our semantic user-facing representation.

ericpgreen2 avatar Jun 16 '22 19:06 ericpgreen2

We should probably have done this after major PRs are merged. This will be a nightmare to merge with huge PRs like the explore one.

AdityaHegde avatar Jun 17 '22 16:06 AdityaHegde

Damn. Well it doesn't make sense for all you with the major PRs outstanding to each have to resolve the merge. So this can wait until those are in main and I'll revisit it then.

ericpgreen2 avatar Jun 17 '22 17:06 ericpgreen2

In the meantime, I can do a much smaller PR to rename the user-facing text, which should be more trivial to merge.

ericpgreen2 avatar Jun 17 '22 17:06 ericpgreen2

In the meantime, I can do a much smaller PR to rename the user-facing text, which should be more trivial to merge.

See #415

ericpgreen2 avatar Jun 17 '22 20:06 ericpgreen2