rill
rill copied to clipboard
TimeDimensionDisplay DST day conversion fix
Checklist
- [x] Manual verification
- [ ] Unit test coverage
- [ ] E2E test coverage
- [x] Needs manual QA?
Summary
Issue addressed:
https://github.com/rilldata/rill/issues/3560#issuecomment-1881384653
Details:
Steps to Verify
- Open 311 Operational Metrics dashboard.
- Set
first_day_of_week: 7 - In Chrome Developer Tools -> Sensors modify Location to
America/New_YorkTimezone ID. - Drill into Median Time to Resolve Ticket (Hours) from main dashboard view
- Adjust date range to Oct 29 - Nov 30 and make sure that metric trends is set to week
- Check that the column header in the TDD shows Nov 5 (Sun) as first day of week.
- Select time subrange ending with Nov 5 by dragging the mouse over the chart.
- Check the subrange control shows Nov 5.
@egor-ryashin @djbarnwal @AdityaHegde Do we have an update on this bug fix? I believe it's still an outstanding issue.
The issue is more complex than I expected @djbarnwal is going to take a look
@djbarnwal I wonder if there're any updates?