rill icon indicating copy to clipboard operation
rill copied to clipboard

TimeDimensionDisplay DST day conversion fix

Open egor-ryashin opened this issue 1 year ago • 3 comments

Checklist

  • [x] Manual verification
  • [ ] Unit test coverage
  • [ ] E2E test coverage
  • [x] Needs manual QA?

Summary

Issue addressed:

https://github.com/rilldata/rill/issues/3560#issuecomment-1881384653

Details:

Steps to Verify

  1. Open 311 Operational Metrics dashboard.
  2. Set first_day_of_week: 7
  3. In Chrome Developer Tools -> Sensors modify Location to America/New_York Timezone ID.
  4. Drill into Median Time to Resolve Ticket (Hours) from main dashboard view
  5. Adjust date range to Oct 29 - Nov 30 and make sure that metric trends is set to week
  6. Check that the column header in the TDD shows Nov 5 (Sun) as first day of week.
  7. Select time subrange ending with Nov 5 by dragging the mouse over the chart.
  8. Check the subrange control shows Nov 5.

image

egor-ryashin avatar Jan 10 '24 15:01 egor-ryashin

@egor-ryashin @djbarnwal @AdityaHegde Do we have an update on this bug fix? I believe it's still an outstanding issue.

AndrewRTsao avatar Feb 05 '24 19:02 AndrewRTsao

The issue is more complex than I expected @djbarnwal is going to take a look

egor-ryashin avatar Feb 07 '24 19:02 egor-ryashin

@djbarnwal I wonder if there're any updates?

egor-ryashin avatar Mar 29 '24 13:03 egor-ryashin