rill icon indicating copy to clipboard operation
rill copied to clipboard

[do not merge] feat/i18n brazilian portuguese

Open fredguth opened this issue 1 year ago • 2 comments

Checklist

  • [ ] Manual verification
  • [ ] Unit test coverage
  • [ ] E2E test coverage
  • [ ] Needs manual QA?

Summary

Issue addressed:

#3547

Details:

This PR intention is to present a minimal working example of how this feature might work.

  • installed svelte-i18n package in web-common
  • used svelte-i18n in welcome message ("i18n" string shows it is reading from json file)
  • used svelte-i18n in ProjectTitle but it seems to be overwritten by yaml file specification.
  • had some difficulties understanding the monorepo, so please let me know if I need to change anything.
  • there is a hardcoded reference to https://github.com/rilldata/rill.git in the project and I could not run it when the remote was my fork
  • change browser language to Brazilian Portuguese and check project main page

Steps to Verify

./rill devtool start localcode co

fredguth avatar Jan 08 '24 03:01 fredguth

I was wondering if there will be anywhere in the UI for the user to change the preferred language. At the moment we show the window.navigator.language and the user can't change it in the webapp.

fredguth avatar Jan 09 '24 02:01 fredguth

I was wondering if there will be anywhere in the UI for the user to change the preferred language. At the moment we show the window.navigator.language and the user can't change it in the webapp.

That's a great question. A language setting is something we should add to the app at some point. We don't yet have a design for this. For the time being, mind if we cut scope and rely on the user's browser setting?

ericpgreen2 avatar Jan 09 '24 15:01 ericpgreen2

Thanks @fredguth for the PR, closing this PR as of now due to inactivity. Please reopen it when ready to proceed.

nishantmonu51 avatar Apr 16 '24 06:04 nishantmonu51