rill icon indicating copy to clipboard operation
rill copied to clipboard

clear out the `--ignore` section of our typescript checks for svelte components

Open bcolloran opened this issue 2 years ago • 0 comments

Currently, our CI basically doesn't type check a huge number of our svelte components. We need to start pulling things out of this list. (And of course we should never add new items!)

npx svelte-check --workspace web-common --no-tsconfig --ignore "src/components/(data-graphic|notifications|column-profile|virtualized-table|menu|modal|chip|overlay|floating-element|data-types|BarAndLabel.svelte|button|preview-table/ConnectedPreviewTable.svelte),src/features/models/workspace/inspector,src/**/workspace,src/features/dashboards/(time-series|leaderboard|time-controls),src/layout/navigation/NavigationEntry.svelte"

checklists

(updated on 2023-11-29 to only show the current state, removing checkboxes already checked) (updated again on 2023-12-14) (updated 2024-02-12) (updated on 2024-02-20)

here are PRs for the last 4 files: https://github.com/rilldata/rill/pull/4053 https://github.com/rilldata/rill/pull/4092 https://github.com/rilldata/rill/pull/4093 https://github.com/rilldata/rill/pull/4110 once these merge this issue can finally be closed!!!

web-common

  • [ ] src/features/dashboards/time-series

    • [ ] MetricsTimeSeriesCharts.svelte
  • [ ] src/features/dashboards/time-controls/

    • [ ] TimeRangeSelector.svelte
    • [ ] TimeControls.svelte
  • [ ] src/components/data-graphic/elements/GraphicContext.svelte

web-local

done!

bcolloran avatar Nov 08 '23 19:11 bcolloran