darkstudio icon indicating copy to clipboard operation
darkstudio copied to clipboard

New RStudio Version (2022.07.0) Breaks --ds-tab-gradient-dark on MacOS

Open grcatlin opened this issue 1 year ago • 2 comments

Hi Riley,

Using RStudio 2022.02.0, --ds-tab-gradient-dark works as expected:

image

However, on the latest build (2022.07.0, and possibly earlier builds) this behavior changes:

image

I guess they must've swapped something only in the Mac version of RStudio because the Windows version on the latest build works fine - I haven't tried Linux.

Thanks for the cool work!

grcatlin avatar Jul 19 '22 18:07 grcatlin

I mistook it for --ds-tab-gradient-light before, it's actually --ds-tab-gradient-dark and is fixed easily by adding .GND-IWGDKS to the following section in the css file:

/* Source editor tab overflow gradient */
.rstudio-themes-flat
  .rstudio-themes-dark-grey
  :-webkit-any(.GGBOEFPDDS, .GD15MCFCCS, .GCHYANPCES, .GEL-OVUBOR, .GND-IWGDKS) {
  background: var(--ds-tab-gradient-dark) !important;
}

grcatlin avatar Jul 20 '22 15:07 grcatlin

@grcatlin I'll get this fixed, thanks for the help. Most of RStudio's css is generated by GWT, and the styled gradients often break with updates.

rileytwo avatar Aug 12 '22 14:08 rileytwo