riker icon indicating copy to clipboard operation
riker copied to clipboard

Enable riker to build in wasm

Open nothingismagick opened this issue 3 years ago • 4 comments

Trying to get Riker to build in a project using:

cargo build --target=wasm32-unknown-unknown

but it failed with:

error[E0599]: no function or associated item named `new_v4` found for struct `uuid::Uuid` in the current scope
   --> /[redacted]/riker-0.4.2/src/actor/actor_cell.rs:609:24
    |
609 |         let id = Uuid::new_v4();
    |                        ^^^^^^ function or associated item not found in `uuid::Uuid`

I did some quick research and discovered that to enable wasm32 ini uuid, the fix is pretty trivial:

uuid = { version = "0.8.1", features = ["v4", "wasm-bindgen"] }

I tested it by locally building riker and also the consuming project. So its a pretty easy win... Thoughts? I can PR if you agree there is no problem with this.

nothingismagick avatar Dec 16 '20 14:12 nothingismagick

I think it's good be able to compile to wasm. But as I see it, the "wasm-bindgen" feature in the uuid crate would pull in an additional dependency.

Can we make this optional behind our own feature?

hardliner66 avatar Dec 16 '20 16:12 hardliner66

I think that would be the way to do it, yes. Will make a PR tomorrow.

nothingismagick avatar Dec 16 '20 16:12 nothingismagick

Any updates on this?

hardliner66 avatar Jan 09 '21 11:01 hardliner66

Ojey, I forgot to do this. Thanks for the reminder!

nothingismagick avatar Jan 09 '21 13:01 nothingismagick