no-style-please icon indicating copy to clipboard operation
no-style-please copied to clipboard

Title renders as link, even with with no url attributes

Open mjawood opened this issue 1 year ago • 12 comments

image

mjawood avatar Nov 04 '24 13:11 mjawood

Hi @jerdftw! I tried reproducing the behaviour and it seems, the Contact doesn't appear as link rather simple plain text.

image

tanvincible avatar Dec 27 '24 12:12 tanvincible

Having the same issue!

sreyfe avatar Jan 09 '25 11:01 sreyfe

Hello @sreyfe! Could you please provide exact reproducible steps and relevant details about your working environment?

tanvincible avatar Jan 09 '25 11:01 tanvincible

Hello @tanvincible ! This is my menu.yml:

entries:
  - title: test
    post_list: true

My Gemfile is the default, except for gem "no-style-please"

sreyfe avatar Jan 09 '25 13:01 sreyfe

Hello @sreyfe! Thanks for providing the relevant details.
I tried reproducing the behaviour, and on my end it seems to work fine.

image

I'd investigate it further, and would get back to you as soon as I can.

tanvincible avatar Jan 09 '25 15:01 tanvincible

This is definitely happening. All you have to do is create a default project with the _data/menu.yml as

entries:
    - title: test

Jekyll 4.4.1 and ruby 3.0.2

bread-man88 avatar Mar 14 '25 19:03 bread-man88

The gem that's getting installed by default is version 0.1.0, which is what I assume is causing this. Trying to figure out why that is, because I've now updated to ruby 3.4.2 which is what I assumed was causing 0.1.0 to be installed once I realized how old my ruby version was.

bread-man88 avatar Mar 14 '25 20:03 bread-man88

When I try to pin to 0.4.9 it gives:

Could not find compatible versions

Because no-style-please >= 0.4.9 depends on jekyll ~> 3.10.0
  and Gemfile depends on jekyll ~> 4.4.1,
  no-style-please >= 0.4.9 cannot be used.
So, because Gemfile depends on no-style-please ~> 0.4.9,
  version solving has failed.

I'm not a ruby person, but it looks like your package requires 3.10.0. The 0.1.0 version required jekyll 4.1. Not sure what's going on there but I'd recommend changing that. The Jekyll quickstart installation installs jekyll 4.4.1 as of this writing, so that's a problem.

Now even when I downgrade to jekyll 3.10.0 and I try to run the server I get 'Kernel.require': cannot load such file -- base64. I give up. I'll use another theme.

bread-man88 avatar Mar 14 '25 20:03 bread-man88

Hello @bread-man88! Thanks for reporting!

I recommend downloading Jekyll v3.10.0 and no-style-please v0.4.9, and ofc ruby v3.4 or higher. These specific versions are supported because the latest (at the time of writing) GitHub Pages gem version is 232 which is compatible with Jekyll v3.10.0. Our main goal here is to keep the deps for the theme and GitHub Pages in sync.

Please do not use no-style-please v0.1.0 as the deps are (very) likely to cause issues.

If you like, you may look at my (publicly hosted) Gemfile. I also use this theme.

tanvincible avatar Mar 15 '25 16:03 tanvincible

Now even when I downgrade to jekyll 3.10.0 and I try to run the server I get 'Kernel.require': cannot load such file -- base64. I give up. I'll use another theme.

Could you please share some more details about your dev env?

tanvincible avatar Mar 15 '25 16:03 tanvincible

@tanvincible

I recommend downloading Jekyll v3.10.0 and no-style-please v0.4.9, and ofc ruby v3.4 or higher. These specific versions are supported because the latest (at the time of writing) GitHub Pages gem version is 232 which is compatible with Jekyll v3.10.0. Our main goal here is to keep the deps for the theme and GitHub Pages in sync.

That's fine, I'm just telling you that that's probably why this issue was initially made and will keep getting reported. I'm sure people are just following the Jekyll quickstart guide, adding the gem "no-style-please" to their Gemfile and not realizing that that's installing 0.1.0. It's just weird that an newer version of Jekyll installs an older version of the package.

Also, on Ruby 3.4.2, Jekyll 3.10.0 and no-style-please 0.4.9 I was getting this 'Kernel.require': cannot load such file -- base64 error when I tried to run the dev server. I realized later using the remote_theme route avoids all this as you don't have to gem install the theme. Never figured out what was going on there. Maybe you can reproduce

bread-man88 avatar Mar 15 '25 16:03 bread-man88

Hm, thanks for this additional info. I'll try to reproduce the behavior. In the meantime, would you mind opening an issue (to keep track)?

tanvincible avatar Mar 15 '25 17:03 tanvincible