no-style-please icon indicating copy to clipboard operation
no-style-please copied to clipboard

Appearance dark does not seem to do anything.

Open nassredean opened this issue 4 years ago • 4 comments

Hello there. I have a basic setup with this theme, and I'm noticing that the specifying "dark" will not change the color scheme of the theme when building. I have the following _config.yml

title: nassredean nasseri
tagline: "| nasseri.io"
author:
  name: Nassredean Nasseri
email: [email protected]
description: "the personal website of nassredean nasseri"
url: "https://nasseri.io"
baseurl: ""
exclude: [scripts/]
favicon: "favicon.png"
permalink: /:slug.html
theme: no-style-please
theme_config:
  appearance: "dark"
  back_home_text: ".." # customize text for homepage link in post layout
  date_format: "%Y-%m-%d" # customize how date is formatted
  show_description: false # show blog description in home page
timezone: America/New_York
plugins:
  - jekyll-sitemap
  - jekyll-feed

I observe that the <body> tag, is not being given an a attribute of any kind after running jekyll build. So it seems like, somehow this line <body a="{{ site.theme_config.appearance | default: "auto" }}"> in https://github.com/riggraz/no-style-please/blob/3432e31045f14ee57dedd1e0653c3d94d19eed01/_layouts/default.html is not working for me.

Is there anything else I need to do to get the dark theme applying correctly? Note that I have no _layouts, _includes, or _posts directory in my site. Not sure if that makes a difference.

nassredean avatar Mar 17 '21 03:03 nassredean

hey, this happens to me too when I host the page locally through "jekyll serve" on my computer but once I uploaded it to githubpages, it works correctly,

may be the "remote-theme" thing

marcelo57 avatar Mar 19 '21 01:03 marcelo57

hey, this happens to me too when I host the page locally through "jekyll serve" on my computer but once I uploaded it to githubpages, it works correctly,

may be the "remote-theme" thing

Indeed this has been happening when using jekyll serve. I don't use githubpages, I just host my stuff in a public s3 bucket and then put a cloudfront distribution in front of it.

Strangely, when I first deployed, I was getting a mixed content warning trying to load the CSS file (despite it being served over http). Somehow this issue got resolved, then I made some change trying to fix the dark theme issue, and the mixed content warning came back. I hacked around it my just inlining the style in the _site directory and deploying that. Obviously not a great solution at all, but my site basically never changes so for that time being I'm just leaving it as is.

nassredean avatar Mar 19 '21 15:03 nassredean

+1

yogeshvar avatar May 04 '22 15:05 yogeshvar

+1

devnix avatar Dec 30 '22 10:12 devnix