quil-rs icon indicating copy to clipboard operation
quil-rs copied to clipboard

Expressions containing NaN are not equal when everything else matches

Open Shadow53 opened this issue 2 years ago • 0 comments

This was surfaced by proptest fuzzing just now. The expression "aa[0]/(pi - pi)" fails the simplification test because NaN != NaN. This follows the IEEE standard, but I think for our purposes it may make sense to make them equal for the purposes of PartialEq for Expression.

Shadow53 avatar Nov 23 '23 00:11 Shadow53