forest-benchmarking icon indicating copy to clipboard operation
forest-benchmarking copied to clipboard

post data structure refactor issues

Open joshcombes opened this issue 5 years ago • 0 comments

  • [x] standardize argument order e.g. my_fun(qpu, qvm, benchmarker, parameters) rather than any old order.
  • [x] standardize argument names and variable names e.g. n_shots vs num_shots; qubit vs qcid vs qb; angles vs phases; excited state or |1>
  • [ ] Fix existing style violation and add style linting (flake8) to the CI/CD pipeline
  • [x] Add type hinting everywhere in the source code, remove from docstrings
  • [x] Standardize return types e.g. aquire_data should return standard error not variances, estimate_X should return standard error not variances

joshcombes avatar May 15 '19 21:05 joshcombes