law icon indicating copy to clipboard operation
law copied to clipboard

Add more logs.

Open riga opened this issue 5 years ago • 2 comments

Way more logs are required to get a sense of what is happening in the background if required. Therefore, most of the logs might have DEBUG level, but certainly some should also have INFO and above.

riga avatar Aug 05 '19 18:08 riga

Have you considered using loguru? Makes logging quite straightforward

choucavalier avatar Aug 25 '23 16:08 choucavalier

Looks good! However, so far I've been hesitating to depend too much on other libraries in the law core for two reasons:

  • For most submission systems we use, we have to send all our software with the jobs (not with particular every job, but we upload our bundled software first to a common location where jobs can pick it up). At least for us, this is quite some motivation to keep the dependencies as streamlined as possible.
  • The sandboxing mechanism (for tasks to switch into bash envs, venvs, docker and singularity containers) is based on the assumption that python, law and its dependencies are available in the sandbox env. This is easy to achieve for bash / venv sandboxes, but for containers this is rarely the case. Or rather: one can't force people to only use containers where law is available. Therefore, a forwarding is in place which places law and its deps into a single directory (via symlinks), and then bind mounts it into the container env. This is not particularly trivial.

riga avatar Aug 26 '23 10:08 riga