srclient icon indicating copy to clipboard operation
srclient copied to clipboard

Missing field in GetSchema

Open lotus-x opened this issue 2 years ago • 1 comments

Hi,

I think References field must be included when constructing the Schema which is fetched using a schema ID

https://github.com/riferrei/srclient/blob/master/schemaRegistryClient.go#L226

Also I checked with the confluent's schema registry, and it does return the references for the request /schemas/ids/%s

lotus-x avatar May 16 '22 04:05 lotus-x

This is a trivial addition, but I want to combine this feature with a test suite I'm workıng on for this library on Github Actions. I don't have a reliable way to test this immediately, if someone can verify the one line change has no bugs for when there are no references, please let me know.

AtakanColak avatar May 24 '22 19:05 AtakanColak

Resolved in #89

AtakanColak avatar Aug 17 '22 17:08 AtakanColak