ansible-gitlab-runner icon indicating copy to clipboard operation
ansible-gitlab-runner copied to clipboard

Switch to gitlab_runner_module for registering runners

Open chancez opened this issue 3 years ago • 1 comments

Generally, i see a lot of regex/command module usage in this role and I believe a lot of the logic could be replaced with python in a module. I see the community.general collection has a gitlab_runner_module https://docs.ansible.com/ansible/latest/collections/community/general/gitlab_runner_module.html but it doesn't support everything needed.

I imagine the module could be updated to handle most of the configuration merging, and runner registration and then replace a good portion of the logic for managing the runner configuration and registration that's done using multiple other tasks/modules today.

chancez avatar Nov 19 '20 19:11 chancez

True, but this has been around for ages. Hence some classic "legacy" i would say. If someone wants to make those changes then i am all for it.

riemers avatar Nov 23 '20 14:11 riemers

Seems this message did not get a lot of love. This does not mean it was not seen but time wise might not have made it to proper attention. This is just the clean up action ;)

github-actions[bot] avatar Jun 23 '23 02:06 github-actions[bot]