ansible-gitlab-runner icon indicating copy to clipboard operation
ansible-gitlab-runner copied to clipboard

Offpeak option is deprecated and will be removed in version 14.

Open jeroenmaelbrancke opened this issue 4 years ago • 7 comments

Hello,

Just wondering how i can configure a subsection under runners.machine? The current offpeak option will be removed with gitlabrunner version 14. The new solution is using the runners.machine.autoscaling option: https://docs.gitlab.com/runner/configuration/autoscale.html#autoscaling-periods-configuration

Current config:

extra_configs:
      runners.machine:
        IdleCount: 1
        IdleTime: 1800
        OffPeakPeriods: ["* * 0-7,18-23 * * mon-fri *", "* * * * * sat,sun *"]
        OffPeakIdleCount: 0
        OffPeakIdleTime: 600
        MachineDriver: 'google'

New config:

extra_configs:
      runners.machine:
        IdleCount: 1
        IdleTime: 1800
        MachineDriver: 'google'
        runners.machine.autoscaling:
          Periods: ["* * 0-7,18-23 * * mon-fri *","* * * * * sat,sun *"]
          IdleCount: 0
          IdleTime: 600

output with the new section:

[runners.machine]
    IdleTime = 1800
    IdleCount = 1
    MachineDriver = "google"
    MachineName = "auto-scale-runner-%s"
    runners.machine.autoscaling = {"Periods": ["* * 0-7,18-23 * * mon-fri *", "* * * * * sat,sun *"], "IdleCount": 0, "IdleTime": 600}

should be:

[runners.machine]
    IdleTime = 1800
    IdleCount = 1
    MachineDriver = "google"
    MachineName = "auto-scale-runner-%s"
    [[runners.machine.autoscaling]]
      Periods = ["* * 0-7,18-23 * * mon-fri *", "* * * * * sat,sun *"]
      IdleCount = 0
      IdleTime = 600

Is there an issue with my config in Ansible or is this not supported yet?

jeroenmaelbrancke avatar Aug 17 '20 14:08 jeroenmaelbrancke

If its spanking new, it might not be supported. Since i don't actively use a gitlab runner anymore its harder to test for me. I just try to maintain the repo with updates and pull request. I might have a good candidate that might want to take it over.

riemers avatar Sep 04 '20 10:09 riemers

I would consider helping maintaining the project, I'm running my CI/CD using self hosted fork of your docker image

Lusitaniae avatar Oct 12 '20 08:10 Lusitaniae

@Lusitaniae that sounds interesting, as you can tell i don't always look i just try to maintain the pr's as best as i can but i don't have the time for the 'new features' let me check with the candidate i had. If he doesn't respond i would like to take you up on it.

riemers avatar Oct 19 '20 09:10 riemers

No need to put all the burden on a single person, can simply add both of us as maintainers in the repo settings.

Lusitaniae avatar Oct 20 '20 06:10 Lusitaniae

Your right, i have added you to the repo. Where you can help out, feel free to merge a PR and make a release just follow the numbering and it will find its way into galaxy automatic.

riemers avatar Oct 20 '20 08:10 riemers

Hello, any update for this issue ?

Totooow avatar Sep 15 '22 18:09 Totooow

Status still the same I still do best effort on the PR’s alone.

riemers avatar Sep 16 '22 12:09 riemers

Seems this message did not get a lot of love. This does not mean it was not seen but time wise might not have made it to proper attention. This is just the clean up action ;)

github-actions[bot] avatar Jun 27 '23 02:06 github-actions[bot]