Samir Halilčević

Results 33 comments of Samir Halilčević

> @riemass anything left to do? Feature wise this is completed, only thing left is to update the examples.

This isn't in the bugprone subset, but I'll add https://clang.llvm.org/extra/clang-tidy/checks/google/explicit-constructor.html

Tried recreating the fail locally and couldn't bring it to fail. I think the test fails on `fedora-39:no-exceptions`, I'll try setting up the runner locally.

The test fails with this check ([link](https://github.com/actor-framework/actor-framework/blob/4145120f2053ae6076d2a5ac86fcf504a284121f/libcaf_core/caf/flow/generation.test.cpp#L248)): ``` Scenario: asynchronous buffers can generate flow items Given: a background thread writing into an async buffer When: canceling the subscription to the...

I've recorded and analyzed a test run that fails and one that succeeds. The vector `res` witch is a sink from the observable has 128 values in the failing run...

> In that case, just switching these two lines should give us a deterministic order, no? You're right. I didn't consider reordering it because I taught it would break the...

Are we axing `actor_pool` for v2? How about I remove the test suite and implementation in a single PR to the release/2 branch, and leave it as is for v1?...

We had four active pipelines running simultaneously the other day, and I think on almost all of them some of the mentioned tests failed. My reasoning here is that the...

Solved one minor error in the mentioned PR. The `std::get` error is somewhat weird, only appears on clang v17.0.6 version for me, clang v18 and v19 don't complain, and I'm...

With the flags `-DCMAKE_CXX_FLAGS="-stdlib=libc++" -DCMAKE_EXE_LINKER_FLAGS="-stdlib=libc++ -lc++abi"`, the code compiles successfully even with Clang 17. The issue appears to be with `libstdc++`'s implementation of `std::get` not working correctly with Clang 17...