grape-middleware-logger icon indicating copy to clipboard operation
grape-middleware-logger copied to clipboard

Error with Grape 2.1.2

Open lavaturtle opened this issue 7 months ago • 0 comments

I recently upgraded from Grape 2.0.0 to Grape 2.1.2, and now I'm seeing an error in grape-middleware-logger when I make any request:

E, [2024-07-08T09:19:46.339918 #9444] ERROR -- : uninitialized constant Grape::Env::RACK_REQUEST_FORM_HASH
	/home/grey/.rvm/gems/ruby-3.3.3@tokyo/gems/grape-middleware-logger-1.12.0/lib/grape/middleware/logger.rb:96:in `parameters'
	/home/grey/.rvm/gems/ruby-3.3.3@tokyo/gems/grape-middleware-logger-1.12.0/lib/grape/middleware/logger.rb:40:in `before'
	/home/grey/.rvm/gems/ruby-3.3.3@tokyo/gems/grape-middleware-logger-1.12.0/lib/grape/middleware/logger.rb:51:in `call!'
	/home/grey/.rvm/gems/ruby-3.3.3@tokyo/gems/grape-2.1.2/lib/grape/middleware/base.rb:27:in `call'
       ...

I assume the Grape::Env::RACK_REQUEST_FORM_HASH constant has been removed in the latest version of Grape. Would it be possible to update grape-middleware-logger to work with Grape 2.1.x? Alternatively, the gemspec should probably specify that the version of grape should be 2.0.0 or less.

lavaturtle avatar Jul 08 '24 13:07 lavaturtle