FreshMvvm icon indicating copy to clipboard operation
FreshMvvm copied to clipboard

Fixes issue 104 (https://github.com/rid00z/FreshMvvm/issues/104)

Open theberserker opened this issue 8 years ago • 5 comments

Fixes issue 104: RemoveFromNavigation and then popping PageModel causes ReverseInit being called on removed FreshBasePageModel, instead of the one being popped.

theberserker avatar Sep 22 '16 13:09 theberserker

This is a pull request as discussed here: https://github.com/rid00z/FreshMvvm/issues/104 Please note that there is minor difference in below line, by what we have discussed: nextPageModel.PreviousPageModel = nextPageModel.PreviousPageModel.PreviousPageModel; is now: nextPageModel.PreviousPageModel = nextPageModel.PreviousPageModel?.PreviousPageModel;

I gusess nextPageModel.PreviousPageModel shouldn't ever be null, but I've just added additional null check just to be on safe side.

Also if this is released soon as a NuGet package it would be just awesome :) Do you have any release plan already?

theberserker avatar Sep 22 '16 14:09 theberserker

@rid00z any status progress on that pull request?

theberserker avatar Apr 14 '17 08:04 theberserker

@rid00z Just wondered if this will be rolled out at any point? As it's causing me an issue currently

silent-k avatar Sep 25 '18 11:09 silent-k

Would be nice to get feedback on this. I'm facing this issue as well.

joanbarros avatar May 14 '19 19:05 joanbarros

Hello, I'm facing this issue as well and still have not found a way of fixing it. I am trying to pass parameters so I really need the reverseInit to work properly.. Any suggestions ?

Stratosf avatar Jan 11 '21 11:01 Stratosf