Rico Picone comments

Results 25 comments of


                                            Rico Picone

tfp.JointDistributionSequential._build() -> line 236, in _build if not isinstance(model, collections.Sequence): AttributeError: module 'collections' has no attribute 'Sequence'

I'm seeing this error in v 0.14.0. As OP says, it should be `collections.abc.Sequence` See https://github.com/modin-project/modin/issues/5168

tfp.JointDistributionSequential._build() -> line 236, in _build if not isinstance(model, collections.Sequence): AttributeError: module 'collections' has no attribute 'Sequence'

This appears to be fixed in the latest: https://github.com/tensorflow/probability/blob/c9d9dd4e6e5520a75ca8f299420589e9a22485a2/tensorflow_probability/python/layers/distribution_layer.py#L167

Importing ABC directly from collections was deprecated from Python 3.4 and will be removed in 3.10

I'm now getting an error with v 0.14.0 and Python 3.10. As OP says, it should be updated to `collections.abc.Sequence` See also #1656

Importing ABC directly from collections was deprecated from Python 3.4 and will be removed in 3.10

This appears to be fixed in the latest: https://github.com/tensorflow/probability/blob/c9d9dd4e6e5520a75ca8f299420589e9a22485a2/tensorflow_probability/python/layers/distribution_layer.py#L167

Windows support

So if last week's PR (@rashedmyt) for simpervisor is accepted, do we expect this to be solved with the next simpervisor release?

newcommand gamma weirdness

Interesting. I hadn't tried others starting with `g`. I'll let you know if I discover anything of relevance.

Added more arguments as options, including -o output file, width and …

@ashafaei if you accept this PR, I'll help update the README

Added more arguments as options, including -o output file, width and …

Oh, I didn't mention that this isn't backward compatible, as-is because I made the positional argument `notwide` into a flag `-n`. If you'd like, I can make it backward-compatible by...

Sympy function support.

Was this ever implemented?

Include fails in nested environment

@CameronDevine I wonder of @owickstrom would be open to a PR?