client_auth_type and client_ca_file configs for mTLS

Open bbeattie-phxlabs opened this issue 4 years ago • 1 comments

https://github.com/ricoberger/script_exporter/blob/master/pkg/config/config.go#L19 limits TLS configuration to crt and key. Is there intent to adopt the https://github.com/prometheus/exporter-toolkit/blob/master/docs/web-configuration.md for things like client_auth_type: RequireAndVerifyClientCert?

Dec 07 '21 18:12 bbeattie-phxlabs

Hi @bbeattie-phxlabs, I wasn't aware of the exporter-toolkit, but it looks very nice.

One problem I came across is that we have to introduce a second configuration file to get it working.

I created a PR (https://github.com/prometheus/exporter-toolkit/pull/77) in the repository so that we can one configuration file for the script_exporter specific stuff and the exporter-toolkit configuration. Let's see what the maintainers are thinking about it.

Dec 10 '21 22:12 ricoberger