Richard Moore comments

Results 635 comments of


                                            Richard Moore

BAD_DATA error when result has '0x'

@heypran Can you include the contract address and network?

IPC Socket Client does not send \n delimiter

Thanks. Testing it out right now...

IPC Socket Client does not send \n delimiter

My version of Geth seems to work fine without the `\n`, but after adding it, Geth still works just peachy.

IPC Socket Client does not send \n delimiter

Not sure why [this commit](https://github.com/ethers-io/ethers.js/commit/474a8ded2b94a563067d3b4dd5f60ec0725b9a27) didn't get linked to from this issue, so posting this comment.

IPC Socket Client does not send \n delimiter

Of course! Sorry for the delay. For those finding this issue in the future, in was merged in [v6.13.5](https://github.com/ethers-io/ethers.js/releases/tag/v6.13.5). Thanks! :)

Fix DoS vulnerability caused by `ws` dependency on v5

Thanks for the snippet. This was addressed when the exploit was announced in v6, but it certainly makes sense to port back into v5 as it is still widely used.

Fix DoS vulnerability caused by `ws` dependency on v5

It’s not really “easy to close”… The v5 branch is 2.5 years old; I’ve spent the last week carefully updating the tests (migrating from Goerli to Sepolia, redeploying contracts, etc),...

Fix DoS vulnerability caused by `ws` dependency on v5

@airdropross I'm still working on this. The problem is that many of the devtools that ethers v5 depended on have drifted out of support. One of the biggest issues has...

Fix DoS vulnerability caused by `ws` dependency on v5

Fixed in [v5.8.0](https://github.com/ethers-io/ethers.js/releases/tag/v5.8.0). Please keep in mind v5 only receives security patches and all new development occurs on the v6 branch. Thanks! :)

in scroll, all the tx.wait() raise exception receipt.confirmations is not a function

What does the object look like? If you console.log it? I’m not sure what scroll is. Link?