Richard Moore
Richard Moore
Is this still an issue? I've been able to successfully use it with MetaMask, as that's how I tested it.
I think it still uses strings. The JSON-RPC API generally uses QUANTITY types for numeric types. I haven’t checked the spec to see it was updated though.
I’m working on overhauling how the ESM version gets generated starting today, which should address this too. :)
Remove which file? I can’t remove those of change the package.json fields without breaking other people.
There are to many different bundlers and projects that consume ethers in various ways, I don’t think I feel comfortable changing the package fields right now. I’m working on better...
The build files are committed for both personal preference and for security reasons. For security, it is possible for the deterministic build in the CI to verify the generated files...
But why not commit them to the same branch then? Then it is obvious what sources they came from.
This should be addressed in [5.0.20](https://github.com/ethers-io/ethers.js/releases/tag/v5.0.20). Please try it out and let me know if you have any more issues. :)
Here is the change: https://github.com/ethers-io/ethers.js/commit/22bd0c76dddef7134618ec70ac1b084a054e616e#diff-867fc130b92f9b215a2f56cb64caf802367a214d62de58b7688b4c56a3893e90 It was part of an overall refactoring of ESM generation, so was not tagged specifically in the commit.
I don’t have time to try this out tonight, but can you try setting your mainFields to `[ "main" ]`. I just looked up some webpack defaults, and it seems...