Richard Moore
Richard Moore
Thanks! Yeah, don’t worry about a PR. I’ll test and make the change. Thanks for the research though. :)
Awesome! Thanks for the info by the way. This definitely didn't used to be the case; all the [test vectors](https://raw.githubusercontent.com/ethers-io/ethers.js/master/packages/testcases/input/wallets/wallet-secretstorage_null-4a9cf99357f5789251a8d7fad5b86d0f31eeb938-a016182717223d01f776149ec0b4a217d0e9930cad263f205427c6d3cd5560e7-.json) generated by Geth have a `"C"` but those generated by...
This has been updated in [v5.7.0](https://github.com/ethers-io/ethers.js/releases/tag/v5.7.0). Try it out and let me know if you have any problems. Thanks! :)
This has been fixed in [v5.7.0](https://github.com/ethers-io/ethers.js/releases/tag/v5.7.0). Thanks! :)
Thanks, I'll look into this right away. I think `0x` is probably the correct thing to return, but it does mean something specific. The data `0x` means that there were...
If you can figure out a root cause, I’d love to improve the WS support. :)
This is a potential security concern, since including the credentials can leak them to unauthorized third parties. The current settings were all selected as they are they default for fetch.
It could be made a configurable option, but this would be a non-backwards compatible change and would be a bit more work than is likely to be prioritized in the...
The v6 branch won't need this, since you can just swap out the fetch operation and make any adjustments manually. If it is added to v5, it needs to occur...
The fetchOptions has been included in [v5.7.0](https://github.com/ethers-io/ethers.js/releases/tag/v5.7.0). Try it out and let me know if there are any problems. :) Thanks! :)